search

the-blue-alliance / the-blue-alliance-ios

An iOS app for accessing information about the FIRST Robotics Competition.
MIT License
76 stars 23 forks source link

Added Match Breakdown for the 2024 game, Crescendo #963

Closed dbravo1990 closed 7 months ago

dbravo1990 commented 7 months ago

Description

Added Match Breakdown for the 2024 game, Crescendo Based layout on the site version of the Match Breakdown Based functionality on previous year's standards

Motivation and Context

There is no breakdown for 2024 yet, so I wanted to get that going before the season is over. Will probably work on 2023 next since it's also missing :)

How Has This Been Tested?

Since this was only a change on the match breakdown page, I tested this against the full site on many different matches to make sure the information was correct. I also added a couple more rows of data that aren't on the site (and let @dracco1993 know about these) that provide more data to uses about the extra RPs:

Screenshots

image

ZachOrr commented 7 months ago

This is awesome! Thank you so much! Let me give this a look soon.

As a heads up - we're blocked right now on shipping updates to the App Store due to Apple's guidelines around needing to support Sign In with Apple. We've done the prerequisite work on the server to support this, but haven't gotten the sign in integrated into iOS yet. I'll have to take another stab at this, since https://github.com/the-blue-alliance/the-blue-alliance-ios/pull/880 seems out of date 😅

dbravo1990 commented 7 months ago

Awesome thanks!

I would offer to provide help but that looks way over my head.

ZachOrr commented 7 months ago

Dropped a new commit here to back out a few unrelated changes. Tests aren't passing on main right now so - going to manually merge.

Thanks for this!