the-canonizer / Canonizer-Beta--Issue-Tracking

Canonizer Beta - Issue Tracking
0 stars 0 forks source link

"As Of" filters (Include review, As of date) should get applied on topic detail page only #54

Closed rupalichavan9860 closed 1 year ago

rupalichavan9860 commented 1 year ago

As of now when user selects "include review " or As of date/view this version - topic/camp name of that selected filter is displaying on all pages instead of live topic/camp name in bread crumbs

As per functionality "as of" filters (Include review, As of date) should get applied on topic detail page only

Please refer attached screenshot : Live topic name : image

Now apply "include review " and observe other pages like "Create New Camp", all history pages, supported camps page As of now it is displaying in review names image

shahab-ramzan commented 1 year ago

PR raised https://github.com/the-canonizer/canonizer-3.0-frontend/pull/597

rupalichavan9860 commented 1 year ago

@shahab-ramzan Verified on all pages except supported camps page . Please refer attached screenshot :

image

rupalichavan9860 commented 1 year ago

@shahab-ramzan The problem persists when a new user applies the review filter and attempts to support the camp.

image

rupalichavan9860 commented 1 year ago

Not fixed

subhancd commented 1 year ago

showing in review name in the message on manage support. Image

shahab-ramzan commented 1 year ago

@vikasranatalentelgia Live topic name should be shown in the Supported camps page as mentioned in the above screenshot.

hassaanCD commented 1 year ago

not fixed

nalwa commented 1 year ago

@rupalichavan9860 i have tested this issue both on local and staging. I am not able to reproduce this. can you please verify once and we can connect for the same.

rupalichavan9860 commented 1 year ago

@nalwa Please refer below topic : https://canonizer3.canonizer.com/support/1754-Regression-27-FEB-2023-re/2-Camp-1-in-review

Please refer attached screenshot : image

nalwa commented 1 year ago

Screenshot from 2023-03-17 13-26-14

@rupalichavan9860 This is what i am getting on staging. and this seems correct to me. please check once.

wahaj-hafeez commented 1 year ago

@rupalichavan9860 This is not produced on my local and staging please have look at this issue

rupalichavan9860 commented 1 year ago

@wahaj-hafeez Please refer steps to reproduce :

  1. Create topic
  2. Create camp "Camp 1"
  3. Create sub camp of "Camp 1" - "Sub camp 1" and Support "Sub camp 1"
  4. Login with User B and change camp name from "Camp 1" to "Camp 1 updated"
  5. Commit changes
  6. Login with User A again
  7. Apply filter "Include Review"
  8. Try to support "Camp 1"

Observe camp name on page : image

hassaanCD commented 1 year ago

@rupalichavan9860 functionality is working fine but "Camp1" only showing after page refresh.

Image

Image

rupalichavan9860 commented 1 year ago

Not Working

image

nalwa commented 1 year ago

@rupalichavan9860 not able to reproduce this case, might be scenarios has changed or may be no longer persist as its been created long back. Screenshot from 2023-06-06 13-10-22

Please verify if the scenario is same when you created the ticket. If its changed i would suggest create seprate ticket so we can stick to that only. please verify one more time.

rupalichavan9860 commented 1 year ago

@nalwa Please refer steps :

  1. User A login - Create topic
  2. User A login - Create camp "Camp 1"
  3. User A login - Create sub camp of "Camp 1" -- "Sub camp 1"
  4. User A login - Support "Camp 1"
  5. Login with User B and support "Sub camp 1"
  6. Login with User B and submit a change(Update camp name) for "Camp 1" -It will be in "In review"
  7. Login with User B- Apply "Include Review" filter and try to support "Camp 1" directly
  8. Observe camp name

image

nalwa commented 1 year ago

@rupalichavan9860 by following above steps i am able to reproduce it. Thank you for re-verifying it. we are looking into this.

rupalichavan9860 commented 1 year ago

Working fine now

rupalichavan9860 commented 1 year ago

Verified on live