the-collab-lab / tcl-23-smart-shopping-list

1 stars 2 forks source link

Sweet Alerts 2 Styling To Match Theme #55

Closed jssckbl closed 3 years ago

jssckbl commented 3 years ago

Description

The following changes addressed the Sweet Alert 2 that we are using throughout the application. We chose to alter the colors used in the Sweet Alerts to more closely resemble the theme of the entire application. Text was updated for some of the Sweet Alerts as well, and a change to the button location and messaging for the Delete confirmation.

As a side note, I came across various Delete button scenarios and confirmations. @apdsrocha pointed us toward this article Primary & Secondary Button Actions which is how we based our order of confirm or cancel delete action buttons, as well as color options. We opted to not use a shade of red for any of the delete buttons at this time.

(Please forgive the look of my tables. I think I spent more time on the before and after and setting up the tables than the actual changes on the code ๐Ÿ˜† )

Related Issue

closes #37

Acceptance Criteria

Type of Changes

Type
:bug: Bug fix
โœ“ :sparkles: New feature
:hammer: Refactoring
:100: Add tests
:link: Update dependencies
:scroll: Docs

Updates

Before And After

Before After
pleaseEnterTokenB pleaseEnterTokenA

| tokenNotFoundB | tokenNotFoundA |

|listSuccessB | listSuccessA|

|UHOHB | UHOHA|

|areYouSureDeleteB | areYouSureDeleteA|

|itemDeleteConfirmB | itemDeleteConfirmA|

|itemAlreadyInListB | itemAlreadyInListA

Testing Steps / QA Criteria

  1. On main run git pull
  2. Run git checkout swal-styling
  3. Run npm install
  4. Run npm start
  5. Try making every mistake you can think of ๐Ÿ˜„ Use the images above to guide you. Do not forget to try with and without a token in local storage
github-actions[bot] commented 3 years ago

Visit the preview URL for this PR (updated for commit dece0d1):

https://tcl-23-shopping-list--pr55-swal-styling-wac4c79g.web.app

(expires Sat, 05 Jun 2021 16:26:20 GMT)

๐Ÿ”ฅ via Firebase Hosting GitHub Action ๐ŸŒŽ