the-collab-lab / tcl-28-smart-shopping-list

1 stars 3 forks source link

Kh new list #20

Closed hulyak closed 3 years ago

hulyak commented 3 years ago

Description

Created a Home component and attached it to "/" route.
Created JSX for the Home page.
Created user tokens when user clicks on "Create a new list" button and save it to localStorage.
Saved the user tokens into "tokens" collection in Firestore.
Redirect the user to the "/list" view after the token is set to localStorage.
If the user has a token, get their token from local storage and directly redirect them to the List component.

Related Issue

3

Acceptance Criteria

Type of Changes

	Type
	:bug: Bug fix
✓	:sparkles: New feature
	:hammer: Refactoring
	:100: Add tests
	:link: Update dependencies
	:scroll: Docs

Updates

Before

After

Testing Steps / QA Criteria

Pull down kh-newList branch to your home repository
npm install
npm start

github-actions[bot] commented 3 years ago

Visit the preview URL for this PR (updated for commit d41083f):

https://tcl-28-shopping-list--pr20-kh-newlist-71gmohdh.web.app

_{(expires Wed, 28 Jul 2021 15:21:55 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

ksiman14 commented 3 years ago

Thanks, all! Sandy, yes, you can put in a clear local storage function eventually if we want to be able to reset the token. And I agree, that is a good idea on the component folder, maybe we should do that when we all get together to merge our PRs?

sandaiiyahh commented 3 years ago

Thanks, all! Sandy, yes, you can put in a clear local storage function eventually if we want to be able to reset the token. And I agree, that is a good idea on the component folder, maybe we should do that when we all get together to merge our PRs?

Ooh, I see. Isa also showed me a way to manually delete the token off the local storage as well, although it didn't work on my end so I would love to go over that with the group as well. And yes, that plan sounds good! Maybe sometime Saturday after the meeting or during office hours? We can chat about it 🤗

meganesu commented 3 years ago

+1 to what everyone else already said. Your code is super clean and easy to read! 👏 I like how you split out the createToken function and kept the JSX really short and sweet. Well done!