Description

Changed AddItem component and added a form with an input for the item and frequency for next purchase using radio buttons
Added item, frequency, and lastPurchasedDate saved state values
Created handleChange function to save user input values (item name & purchase frequency) to state
Used getToken() in a useEffect() to set token inside localStorage, but we will have to change that after Kelsey and Hulya's PR gets approved and we merge our branches together
Attached name, frequency, token, and lastPurchasedDate to the item template and added it to the firestore database
Added an alert that gives feedback to user indicating that the item was added to their list. After the alert, the user is redirected to the item list view
The list view has been changed to render an unordered list of items, showing the item names
NOTE: The item list is in a random order currently

Related Issue

4

Acceptance Criteria

User is presented with a form that allows them to enter the name of the item and select how soon they anticipate needing to buy it again (Soon, Kind of Soon, Not Soon)
When the user submits the form, the item is saved to the database, associated with the user’s token
Along with the item name, an integer corresponding to the estimated number of days until next purchase is saved: 7 for “Soon”, 14 for “Kind of Soon”, and 30 for “Not Soon”
The last purchased date should be set to null initially (i.e. you can create an item without purchasing it)
Item names should be displayed as a simple, unordered list on the list view after they’re added

Type of Changes

	Type
	:bug: Bug fix
✓	:sparkles: New feature
	:hammer: Refactoring
	:100: Add tests
	:link: Update dependencies
	:scroll: Docs

Updates

Before

After

add-item-form

item-list

Testing Steps / QA Criteria

Pull down sd-ia-addnewitem branch
npm start

github-actions[bot] commented 3 years ago

Visit the preview URL for this PR (updated for commit 86a1779):

https://tcl-28-shopping-list--pr21-sd-ia-addnewitem-mj42cymn.web.app

_{(expires Thu, 29 Jul 2021 00:29:15 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

meganesu commented 3 years ago

Should we refactor it so that there is a default selection (and frequency) that is 7, 14, or 30 days?

Following up on this, plus @isaabutaa's suggestion on Slack: "If instead of giving it a default value of 0 or 7, maybe we can have a null default value if it's just a one time purchase. And then if they select another value, it'll swap out the default value."

To start with the simplest solution, I'd suggest making the field required (either by picking one of the existing values as a default for now, or preselecting one of the radio buttons when the form loads). And then you can create an additional issue to improve that behavior later on, if we have time. (That issue will also be a good place to track conversation about possible approaches!)

Great collaboration, team! 💪 🥳

sandaiiyahh commented 3 years ago

As I was working on adding the id's, I realized we should also add an error handler for when a user submits an empty item input, which we can definitely implement in the future!

isaabutaa commented 3 years ago