the-collab-lab / tcl-28-smart-shopping-list

1 stars 3 forks source link

Hulya, Isa- Join Existing List #25

Closed hulyak closed 3 years ago

hulyak commented 3 years ago

Description

Related Issue

5

Acceptance Criteria

Type of Changes

Type
:bug: Bug fix
:sparkles: New feature
:hammer: Refactoring
:100: Add tests
:link: Update dependencies
:scroll: Docs

Updates

Before

Screen Shot 2021-07-27 at 4 29 46 PM

After

Screen Shot 2021-07-27 at 4 28 37 PM Screen Shot 2021-07-27 at 4 29 03 PM

Testing Steps / QA Criteria

NOTE: We cannot use tokens that were created before yesterday to join existing lists. But every new token created here on out should work.

github-actions[bot] commented 3 years ago

Visit the preview URL for this PR (updated for commit 61bacf8):

https://tcl-28-shopping-list--pr25-hi-joinlist-wctjtz77.web.app

(expires Thu, 05 Aug 2021 23:35:25 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

ksiman14 commented 3 years ago

Hulya and Isa - All works as expected, great job!! I don't have any additional comments at this point.