Clear search aria label on button - Githubissues

the-collab-lab / tcl-28-smart-shopping-list

1 stars 3 forks source link

Clear search aria label on button #35

Closed ksiman14 closed 3 years ago

ksiman14 commented 3 years ago

Description

Added aria-label "Clear search" to X button next to filter input

Related Issue

closes #34

Acceptance Criteria

[x] Buttons with ambiguous text contain aria-labels

Type of Changes

	Type
	:bug: Bug fix
	:sparkles: New feature
✓	:hammer: Refactoring
	:100: Add tests
	:link: Update dependencies
	:scroll: Docs

Updates

Before

Screen Shot 2021-08-16 at 4 00 47 PM

After

Screen Shot 2021-08-16 at 4 00 03 PM

Testing Steps / QA Criteria

Pull down branch sd-ks-aria-label
npm start
Either open an existing list or create a new list
Type anything in the filter input field
Open Chrome console's Element inspector and hover over the "X" button
The Name in the popup should read "clear search"

github-actions[bot] commented 3 years ago

Visit the preview URL for this PR (updated for commit 4eb3534):

https://tcl-28-shopping-list--pr35-sd-ks-aria-label-rjbdqyqu.web.app

_{(expires Mon, 23 Aug 2021 22:07:10 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}