Kelsey Sandy Delete Item - Githubissues

the-collab-lab / tcl-28-smart-shopping-list

1 stars 3 forks source link

Kelsey Sandy Delete Item #36

Closed sandaiiyahh closed 3 years ago

sandaiiyahh commented 3 years ago

For an example of how to fill this template out, see this Pull Request.

Description

created a delete button in SingleItem component with a function handleDelete that will be invoked when a user presses on it
added confirm message to make sure user wants to delete an item
if the user confirms, the item is deleted from the current view and the firestore

Related Issue

closes #11

Acceptance Criteria

[x] User is able to delete an item from the shopping list
[x] Before deleting, prompt the user to confirm that they really want to delete the item to prevent accidental deletions
[x] Deletion should cause the associated record(s) in the database to be deleted

Type of Changes

	Type
	:bug: Bug fix
✓	:sparkles: New feature
	:hammer: Refactoring
	:100: Add tests
	:link: Update dependencies
	:scroll: Docs

Updates

Before

Screen Shot 2021-08-16 at 6 26 56 PM

After

List view with 'gummy':

Screen Shot 2021-08-16 at 6 25 37 PM

Firestore:

Screen Shot 2021-08-16 at 6 26 01 PM

When you try to delete 'gummy':

Screen Shot 2021-08-16 at 6 26 08 PM

After 'gummy' was deleted:

Screen Shot 2021-08-16 at 6 26 24 PM

Firestore:

Screen Shot 2021-08-16 at 6 26 15 PM

Testing Steps / QA Criteria

pull down ks-sd-delete-item
checkout to branch
navigate to list view
click on Delete button
there should be a pop up asking you to confirm whether you want to delete the item
if you clicked yes, item is deleted from list view and firestore
if you clicked no, item remains in list and firestore

github-actions[bot] commented 3 years ago

Visit the preview URL for this PR (updated for commit 2f9d09f):

https://tcl-28-shopping-list--pr36-ks-sd-delete-item-90v3utlw.web.app

_{(expires Mon, 23 Aug 2021 22:32:54 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}