the-collab-lab / tcl-28-smart-shopping-list

1 stars 3 forks source link

Isa - reusable button component #53

Closed isaabutaa closed 3 years ago

isaabutaa commented 3 years ago

Description

Related Issue

Closes #45

Acceptance Criteria

Create a reusable button component that will be used throughout the application

AC

Type of Changes

Type
:bug: Bug fix
βœ“ :sparkles: New feature
βœ“ :hammer: Refactoring
:100: Add tests
:link: Update dependencies
:scroll: Docs

Updates

Before

image image

After

image image image image

Testing Steps / QA Criteria

github-actions[bot] commented 3 years ago

Visit the preview URL for this PR (updated for commit 9712b12):

https://tcl-28-shopping-list--pr53-ia-button-component-w3l1r3tm.web.app

(expires Thu, 09 Sep 2021 00:34:03 GMT)

πŸ”₯ via Firebase Hosting GitHub Action 🌎

isaabutaa commented 3 years ago

It might just be me but the inputs are not working anymore? I am able to add an empty item to the list, or not have to submit a frequency and still add the item. I also am not able to join an existing list :( But everything else works fine! Would love to confirm as it might just be me.

Thank you @sandaiiyahh for the feedback! πŸ™ I'm going to check it out and see what's going on there.