Closed sandaiiyahh closed 3 years ago
Visit the preview URL for this PR (updated for commit da3cf75):
https://tcl-28-shopping-list--pr60-sd-input-component-40oqufh4.web.app
(expires Thu, 09 Sep 2021 00:52:33 GMT)
π₯ via Firebase Hosting GitHub Action π
Good job, Sandy! I can use the input field to enter an existing token, filter items, and add an item. to the list. Just I cannot see the placeholder text. I don't know what is causing that.
Ooh thanks for catching that Hulya! I changed it last minute and forgot to look over it. I was passing placeholder as props but forgot to change the βlabelβ to placeholder in the Input component. Will update tomorrow!
This looks great @sandaiiyahh! I love the styling with the green outline when you're typing in the input field. Only comment I have is the same comment as Hulya on the placeholder text π
Yeah it was part of Hulya and Isa's UI theme! I was thinking we might need to change have a white background over the main part of the app though, to see everything a bit better π§
For an example of how to fill this template out, see this Pull Request.
Description
Input
reusable component using Material UI'sTextField
Input
component takes in props (label, name, value, onChange, required) Thank you @isaabutaa for the amazing idea! π€©Input
component to entering an existing token, filtering items, and adding a new itemRelated Issue
closes #47
Acceptance Criteria
Type of Changes
Updates
Before
After
Testing Steps / QA Criteria
sd-input-component
sd-input-component