the-collab-lab / tcl-28-smart-shopping-list

1 stars 3 forks source link

Sd input component #60

Closed sandaiiyahh closed 3 years ago

sandaiiyahh commented 3 years ago

For an example of how to fill this template out, see this Pull Request.

Description

Related Issue

closes #47

Acceptance Criteria

Type of Changes

Type
:bug: Bug fix
βœ“ :sparkles: New feature
βœ“ :hammer: Refactoring
:100: Add tests
:link: Update dependencies
:scroll: Docs

Updates

Before

Screen Shot 2021-08-31 at 10 02 59 PM Screen Shot 2021-08-31 at 10 03 34 PM Screen Shot 2021-08-31 at 10 03 39 PM

After

Screen Shot 2021-08-31 at 9 59 43 PM Screen Shot 2021-08-31 at 10 00 00 PM Screen Shot 2021-08-31 at 10 00 33 PM

Testing Steps / QA Criteria

github-actions[bot] commented 3 years ago

Visit the preview URL for this PR (updated for commit da3cf75):

https://tcl-28-shopping-list--pr60-sd-input-component-40oqufh4.web.app

(expires Thu, 09 Sep 2021 00:52:33 GMT)

πŸ”₯ via Firebase Hosting GitHub Action 🌎

sandaiiyahh commented 3 years ago

Good job, Sandy! I can use the input field to enter an existing token, filter items, and add an item. to the list. Just I cannot see the placeholder text. I don't know what is causing that.

Screen Shot 2021-08-31 at 9 18 15 PM

Ooh thanks for catching that Hulya! I changed it last minute and forgot to look over it. I was passing placeholder as props but forgot to change the β€œlabel” to placeholder in the Input component. Will update tomorrow!

sandaiiyahh commented 3 years ago

This looks great @sandaiiyahh! I love the styling with the green outline when you're typing in the input field. Only comment I have is the same comment as Hulya on the placeholder text 😊

Yeah it was part of Hulya and Isa's UI theme! I was thinking we might need to change have a white background over the main part of the app though, to see everything a bit better 🧐