the-collab-lab / tcl-28-smart-shopping-list

1 stars 3 forks source link

Hulya - Welcome page #64

Closed hulyak closed 3 years ago

hulyak commented 3 years ago

Description

Note: I think we can have more space between the lettuce image and GreenButton. I have tried to edit GreenButton, but styling didn't apply. Maybe we can play with it, later!

Edits:

Related Issue

closes #63

Acceptance Criteria

Type of Changes

Type
:bug: Bug fix
:sparkles: New feature
:hammer: Refactoring
:100: Add tests
:link: Update dependencies
:scroll: Docs

Updates

Before

Screen Shot 2021-09-01 at 7 09 10 PM

After

Screen Shot 2021-09-01 at 7 05 07 PM Screen Shot 2021-09-01 at 7 05 26 PM Screen Shot 2021-09-01 at 7 05 39 PM

Testing Steps / QA Criteria

github-actions[bot] commented 3 years ago

Visit the preview URL for this PR (updated for commit 6e3b2fe):

https://tcl-28-shopping-list--pr64-welcome-page-1g37v5lt.web.app

(expires Thu, 09 Sep 2021 15:41:17 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

isaabutaa commented 3 years ago

Nice job with this @hulyak! I see you added some more typography styling to keep it consistent throughout - that's awesome. In regards to increasing the margin for the GreenButton, you could do it by editing the styling for MuiButton inside of src/themes/theme.js:

MuiButton: { root: { borderRadius: '25px', margin: '8px', // you could edit the margin here }, },

I probably should have gotten rid of the GreenButton.css file because it doesn't actually work. 🤦‍♂️