Am at join existing list

[andreamartz]

Description

Tokens can be shared with other users to allow them to co-manage a given list.

We created a new form component (TokenForm) so that the user can enter an existing token to share in ownership of an existing list. TokenForm replaces the input and button that were previously in the Home component.

Joining an existing list consists of the following:

• User enters an existing token
• Save the token to localStorage
• Show the user the existing list

Related Issue

closes #5

Acceptance Criteria

AC:

• [x] When the user does not already have a token in localStorage, on the onboarding/home screen, a simple form is displayed that allows the user to enter a token
• [x] Entering the token and hitting submit saves the token to localStorage, effectively giving them joint control of the list
• [x] On submit, show an error if the token does not exist
• [x] If they get an error message, allow them to try again or create a new list

Type of Changes

	Type
	:bug: Bug fix
✓	:sparkles: New feature
✓	:hammer: Refactoring
	:100: Add tests
	:link: Update dependencies
	:scroll: Docs

Updates

Before

After

The UI looks similar to the way it looked previously, but now the input and button are actually a form component:

A user enters a token that does not match any shopping list items and sees an error message.

[github-actions[bot]]

Visit the preview URL for this PR (updated for commit 966949d):

https://tcl-31-smart-shopping-list--pr21-am-at-join-existing-opfmtel0.web.app

_{(expires Wed, 27 Oct 2021 23:22:29 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

[bajancode]

I'm having an issue when I try on the github preview link and when I run locally, not sure if it's just I'm not running it properly...but here's the steps I'm going through and what happens: 1) Create new list / token 2) Enter an item 3) Go to list view 4) The new item is not showing up in the list view, but it is showing up in the database

Not sure if it's just something I'm doing wrong!!

[abidishajia]

@bajancode I was just about to write the same thing. The added items aren't showing in the list view although they get saved in the database.

[bajancode]

I'm having an issue (which one again I think is probably just me not running things properly??) but it's happening in github preview and when I try to run the files locally: 1) Generate new list / token, and copy/paste the token from my console 2) Enter an item 3) Clear tokens from local storage, go back to home page 4) Enter the token in the form you created on the home page 5) Getting the "Please enter a valid token" message

I think perhaps this is just my not understanding how the token memory / storage works, but if anyone has any idea what I'm doing wrong would love to hear!!

[gabynr]

I think the problem is in AddForm. We need to set the token that is in locaStorage. Yesterday, we need to change it in AddForm, because when you create a list always you use the token that is in const userToken, and that const never changes. Because we need to set with token is in localStorage. I think this change is implicit in this Criterias

Sent from my iPhone

On Oct 18, 2021, at 9:34 PM, bajancode @.***> wrote:

 I'm having an issue (which one again I think is probably just me not running things properly??) but it's happening in github preview and when I try to run the files locally:

Generate new list / token, and copy/paste the token from my console Enter an item Clear tokens from local storage, go back to home page Enter the token in the form you created on the home page Getting the "Please enter a valid token" message I think perhaps this is just my not understanding how the token memory / storage works, but if anyone has any idea what I'm doing wrong would love to hear!!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.