search

the-collab-lab / tcl-31-smart-shopping-list

1 stars 0 forks source link

18. Implement colour scheme #44

Closed bajancode closed 3 years ago

bajancode commented 3 years ago

Implement colours suggested in issue: https://github.com/the-collab-lab/tcl-31-smart-shopping-list/issues/36

Review app and see if there are any "missed" areas for colour consistency, ie. the input fields may have grey or white backgrounds, ensure they are consistent if needed. Material UI should do most of that already but just in case.

If once the colours are up and they actually don't look as good as we'd expect them to, feel free to play around and make more tweaks and suggestions to possible colours, ensuring they are accessible

Acceptance criteria:

gabynr commented 3 years ago

I can't see the code. Do you push your change ?

bajancode commented 3 years ago

I pushed it to this branch:

https://github.com/the-collab-lab/tcl-31-smart-shopping-list/tree/implement-color-scheme

Thanks!!

On Thu, Nov 25, 2021, 7:38 AM gabynr @.***> wrote:

I can't see the code. Do you push your change ?

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/the-collab-lab/tcl-31-smart-shopping-list/issues/44#issuecomment-979130600, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMSBG4UP7W75NTYHBLNPLZLUNYN4XANCNFSM5IP6Y7KQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

bajancode commented 3 years ago

Thanks @gabynr! In response to your question over in the typography issue: It's not that behaviour, it's all of their outlines go grey for a given colour if I change it to Material UI's shade which aligns with our colour scheme. Even if I haven't selected any items.

green[800] is the colour from the colour scheme, and I was able to add it to the Radio buttons.

But here is what happens if I uncomment those lines trying to use green[800] (I also just tried using a hex number here but it didn't work)

image

gabynr commented 3 years ago

I need to pull this branch, because I don't understand what happened, but I finish for today. I'm going to sleep. I'll check this for tomorrow night, please, wait for me.

bajancode commented 3 years ago

Okay I will wait! Though if we have office hours I'll see if I can get some help with it!

On Fri, Nov 26, 2021, 1:02 AM gabynr @.***> wrote:

I need to pull this branch, because I don't understand what happened, but I finish for today. I'm going to sleep. I'll check this for tomorrow night, please, wait for me.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/the-collab-lab/tcl-31-smart-shopping-list/issues/44#issuecomment-979698474, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMSBG4SSKUPUGA3JRNZ6AUTUN4IERANCNFSM5IP6Y7KQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

gabynr commented 3 years ago

Ok. I have a question. Why didn't you take a color from material UI?. https://mui.com/customization/color/ because In the checklist we don't set the color fixed. the color is set by the function getClassName(item) and it returns the name of the color and in the checklist set the tone of the color (getClassName(item)[800]), for that reason we need to use the color from MateriaUI.

bajancode commented 3 years ago

The colours are from Material UI, that Andrea had picked out, ie. The green is the green[800].

The only that isn't is I changed the orange to be the same as the one Aidan used on the homepage because everyone liked how that looked already and the graphics were also chosen which worked with the colours he'd picked. But maybe we could change the welcome page main colours if it is too much hassle to customize here