updated no items view - Githubissues

the-collab-lab / tcl-31-smart-shopping-list

1 stars 0 forks source link

updated no items view #58

Closed aidantorrence closed 3 years ago

aidantorrence commented 3 years ago

Description

Updates add items view with material UI. Fixes bug where it goes to the Add page from the no items page.

Related Issue

closes #50

Acceptance Criteria

AC:

[ ] When user has no items in their list, they are greeted by a message prompting them to add something to the list which is consistent with the colour, look, feel, and typography of the rest of the app
[ ] (Optional) an image of an orange or similar accompanying the message

Type of Changes

	Type
✓	:bug: Bug fix
✓	:sparkles: New feature
✓	:hammer: Refactoring
	:100: Add tests
	:link: Update dependencies
	:scroll: Docs

Updates

Before

After

github-actions[bot] commented 3 years ago

Visit the preview URL for this PR (updated for commit 2ce8e19):

https://tcl-31-smart-shopping-list--pr58-no-items-page-7wwdhwyy.web.app

_{(expires Thu, 02 Dec 2021 16:59:00 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

bajancode commented 3 years ago

It works for me!

If we had more time I'd suggest maybe putting Welcome, Friend! on a different line than the others, but it works and gets the job done for now!

Using Material UI makes the button look pretty consistent with the rest of the page which is another bonus!