Welcome page styles and more accessibility - Githubissues

the-collab-lab / tcl-31-smart-shopping-list

1 stars 0 forks source link

Welcome page styles and more accessibility #66

Closed bajancode closed 2 years ago

bajancode commented 2 years ago

Description

This changed the welcome page (and to a lesser extent list page) styles to ensure they met accessibility criteria, and importantly, were responsive on smaller sized devices (eliminated horizontal scrolling, etc.)

Related Issue

Closes https://github.com/the-collab-lab/tcl-31-smart-shopping-list/issues/13 and https://github.com/the-collab-lab/tcl-31-smart-shopping-list/issues/48

Acceptance Criteria

NOTE: While I was able to go through and manually implement everything from the a11y checklist, I am still finding that if I use a screen reader such as Google Screen Reader, some important parts are left out, including Buttons on the Welcome page, and for some reason all of the List page! I have not troubleshooted this yet, but if you have any ideas I would love to hear them!

Type of Changes

	Type
	:bug: Bug fix
	:sparkles: New feature
✓	:hammer: Refactoring
	:100: Add tests
	:link: Update dependencies
	:scroll: Docs
✓	😎 : Styles

Updates

Before

Browser

Mobile (using iphone 5, the smallest screen that is generally developed for today)

adoring-shirley-b15129 netlify app_list(iPhone 5_SE) (3)

After

Browser

Mobile

localhost_3000_(iPhone 5_SE) localhost_3000_(iPhone 5_SE) (1) localhost_3000_list(iPhone 5_SE)

netlify[bot] commented 2 years ago

✔️ Deploy Preview for adoring-shirley-b15129 ready!

🔨 Explore the source changes: 9d61b42ad3965eacaed7344849485928c8fca009

🔍 Inspect the deploy log: https://app.netlify.com/sites/adoring-shirley-b15129/deploys/61b1d77d81f43900072172d1

😎 Browse the preview: https://deploy-preview-66--adoring-shirley-b15129.netlify.app/

github-actions[bot] commented 2 years ago

Visit the preview URL for this PR (updated for commit 9d61b42):

https://tcl-31-smart-shopping-list--pr66-welcome-page-styles-ge2ncthc.web.app

_{(expires Thu, 16 Dec 2021 10:18:38 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}