Closed lindseyindev closed 2 years ago
Visit the preview URL for this PR (updated for commit bd28863):
https://tcl-36-smart-shopping-list--pr18-am-ld-additem-gwt5h83c.web.app
(expires Tue, 25 Jan 2022 04:03:35 GMT)
🔥 via Firebase Hosting GitHub Action 🌎
Alena and I spoke about separating the form into components for example we used the radio button 3 times, @djtaylor8 @shelleymcq do you think we should separate the radio buttons or any part into their own components and would this make it more or less readable for you two? Please let @alenamedved and I know! Or if you have any suggestions for making this code more future-proof!
Alena and I spoke about separating the form into components for example we used the radio button 3 times, @djtaylor8 @shelleymcq do you think we should separate the radio buttons or any part into their own components and would this make it more or less readable for you two? Please let @alenamedved and I know! Or if you have any suggestions for making this code more future-proof!
Hmm I don't think a radio button needs to be pulled out into its own component. The entire form itself could be a component, but getting too granular and breaking it down further seems unnecessary. I think what you both did in the form works well!
PR notes are A+ - loving the testing steps and screenshots. Covers info for PMs, other devs, and QA quite well, and screenshot is extra effort that pays dividends with time, since as code changes, it's harder and harder to visually preview the app at this point in time.
Description
Related Issue
Closes #4
Acceptance Criteria
[x] User is presented with a form that allows them to enter the name of the item and select how soon they anticipate needing to buy it again (Soon, Kind of Soon, Not Soon)
[x] When the user submits the form, the item is saved to the database, associated with the user’s token
[x] Along with the item name, an integer corresponding to the estimated number of days until next purchase is saved: 7 for “Soon”, 14 for “Kind of Soon”, and 30 for “Not Soon”
[x] The last purchased date should be set to null initially (i.e. you can create an item without purchasing it)
[x] Item names should be displayed as a simple, unordered list on the list view after they’re added
Type of Changes
Updates
Before
After
Testing Steps / QA Criteria
From your terminal navigate to the main branch using
git checkout main
, create a local branch withgit checkout -b am-ld-addItem
and pull down our branch withgit pull origin am-ld-addItem