the-collab-lab / tcl-36-smart-shopping-list

1 stars 2 forks source link

checkbox refactoring #40

Closed alenamedved closed 2 years ago

alenamedved commented 2 years ago

Had to implement some logic changes:

Related Issue

Closes #33

Acceptance Criteria

-user should be able to uncheck item if it was checked by mistake. -checking item enable a submit button by clicking which data is being send to database -checked item disabled and persist checked for 24 hours so user is not tempted to try to uncheck it

Type of Changes

Type
:bug: Bug fix
:sparkles: New feature
:hammer: Refactoring
:100: Add tests
:link: Update dependencies
:scroll: Docs

Updates

Before

before

After

afterCheckbox afterCheckboxSuccessM

Testing Steps / QA Criteria

github-actions[bot] commented 2 years ago

Visit the preview URL for this PR (updated for commit 14bcda9):

https://tcl-36-smart-shopping-list--pr40-am-checkbox-refactor-pz5d9fjh.web.app

(expires Sun, 06 Mar 2022 04:23:50 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

alenamedved commented 2 years ago

Filling like it is a lot of space for improvement, please, check and let me know what do you think

djtaylor8 commented 2 years ago

Maybe we should add a success toast message? That could be a TODO for design stuff too...

rudidev08 commented 2 years ago

Bravo on using ES6 JS features (arrow functions, spread operator, etc)