the-collab-lab / tcl-36-smart-shopping-list

1 stars 2 forks source link

Refactoring render for empty groups #41

Closed lindseyindev closed 2 years ago

lindseyindev commented 2 years ago

Description

We added conditional logic in the render so that if a group has no items filtered to it, that group will display a message indicating no items match so that the user understands why that group is empty. We decided to still display the group section so that the user can get an idea of the sorting functionality and predictive capabilities of the list even if they have no items to match that list.

Additional refactoring including accordion style containers was discussed but to prevent feature creep we decided to implement conditional rendering first with the option for UI and structural refactoring asynchronously.

Related Issue

closes #32

Acceptance Criteria

Type of Changes

Type
:bug: Bug fix
:sparkles: New feature
:hammer: Refactoring
:100: Add tests
:link: Update dependencies
:scroll: Docs

Updates

Before

empty group with no items

After

with no items text added

rudidev08 commented 2 years ago

Nothing to add, looks great

github-actions[bot] commented 2 years ago

Visit the preview URL for this PR (updated for commit 58befdb):

https://tcl-36-smart-shopping-list--pr41-sm-ld-empty-group-tvuh3dg5.web.app

(expires Sun, 06 Mar 2022 17:23:53 GMT)

🔥 via Firebase Hosting GitHub Action 🌎