the-collab-lab / tcl-65-smart-shopping-list

1 stars 1 forks source link

Ld po #7 welcoming prompt #22

Closed patty-rose closed 1 year ago

patty-rose commented 1 year ago

Description

This PR adds a button that navigates to the add-item page, and text that welcomes a user to an empty list. This welcoming text and button is conditional, only displaying when a list is empty.

Related Issue

closes #7

Acceptance Criteria

Type of Changes

Type
:bug: Bug fix
:sparkles: New feature
:hammer: Refactoring
:100: Add tests
:link: Update dependencies
:scroll: Docs

Updates

Before

Screenshot 2023-09-04 at 7 44 58 PM

After

https://github.com/the-collab-lab/tcl-65-smart-shopping-list/assets/101524326/27a596d6-c0fa-4bef-a856-ac9cb8daf1a2

Testing Steps / QA Criteria

-use GH preview. -clear localStorage in the "application" tab inside dev tools. -create a new list on the Home page. -from the List page verify the welcome message and add item button display. -click add item button to verify it directs you to the Add-item page.

github-actions[bot] commented 1 year ago

Visit the preview URL for this PR (updated for commit 9d230ac):

https://tcl-65-smart-shopping-list--pr22-ld-po-7-welcoming-p-gydmjuot.web.app

(expires Tue, 12 Sep 2023 03:02:11 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: a91b8fb0f37677e20d8afa3e8ea496251536f9b8

lydiadunning commented 1 year ago

I think we just copied the text from the wireframe, it could definitely have more personality.