the-collab-lab / tcl-65-smart-shopping-list

1 stars 1 forks source link

Issue #11 | added delete functionality #29

Closed patty-rose closed 1 year ago

patty-rose commented 1 year ago

Description

This PR adds delete functionality to list items in a list. We used firebase deleteDoc() to delete on the backend, and we also incorporated a confirm dialog box to handle confirming that the user wants to delete.

Related Issue

closes #11

Acceptance Criteria

Type of Changes

Type
:bug: Bug fix
βœ“ :sparkles: New feature
:hammer: Refactoring
:100: Add tests
:link: Update dependencies
:scroll: Docs

Before

Screenshot 2023-09-19 at 4 51 03 PM

After

https://github.com/the-collab-lab/tcl-65-smart-shopping-list/assets/101524326/2e5231cb-fe7f-4b0c-8038-6748ca18d1e7

Testing Steps / QA Criteria

github-actions[bot] commented 1 year ago

Visit the preview URL for this PR (updated for commit 4dc86a3):

https://tcl-65-smart-shopping-list--pr29-sb-po-add-delete-fun-za9onqob.web.app

(expires Tue, 03 Oct 2023 02:06:19 GMT)

πŸ”₯ via Firebase Hosting GitHub Action 🌎

Sign: a91b8fb0f37677e20d8afa3e8ea496251536f9b8

patty-rose commented 1 year ago

@isaiahasanchez Thanks! Those are great ideas. I added basic error handling that console logs an error. And I'll make an issue card for your JS dialog box concern. :)