the-collab-lab / tcl-67-smart-shopping-list

https://tcl-67-smart-shopping-list.web.app/
3 stars 1 forks source link

Bug: hitting enter in add item form does not work #102

Open jtkabenni opened 5 months ago

flbarfield commented 5 months ago

I actually wanted to talk about this!

While hitting enter while in an input field is the expected user experience, it may be more troublesome if the user meant to add a specific reminder duration. Because in that case, they would have to tab down to the list, delete the item, tab back up, and then re-add the item, all the while making extra DB calls...And all of those extra steps could be avoided if we only allow them to add the item when hitting enter when the "add item" button is in focus

Maybe we could display an error message on enter key if that input is focused, and the user hasn't selected a duration? Should it react the same when clicking add item without a duration selected?

jtkabenni commented 5 months ago

Thanks for clarifying @flbarfield, that makes a lot of sense. I'm not too sure on the accessibility of i all but I do remember something about wanting to allow the use to submit forms by hitting enter? It would work since we already have a default selected for 7 days. I guess this would be an issue if they did want to select another duration. We can keep it like this but revisit it when we get to our accessibility ticket later.