Closed flbarfield closed 5 months ago
github-actions[bot]
commented
5 months ago Visit the preview URL for this PR (updated for commit d0e0ff2):
https://tcl-67-smart-shopping-list--pr120-feature-mobile-foote-uo7ls4z2.web.app
(expires Thu, 11 Apr 2024 20:12:31 GMT)
🔥 via Firebase Hosting GitHub Action 🌎
Sign: 1dc6f6876568bd8a1c97781eec7984835c207f7c
aberger3647
commented
5 months ago Yeah maybe we could make another issue for adding the width to the component. Yay more issues
On Thu, Apr 4, 2024 at 12:29 PM Fredrick Barfield @.***> wrote:
@.**** commented on this pull request.
In src/views/Layout.jsx https://github.com/the-collab-lab/tcl-67-smart-shopping-list/pull/120#discussion_r1552129544 :
</header>
- {isMobile && (
Ah for some reason, I thought we had struggled with setting button width width last night for some reason or another.
But yeah, if the component can do it, may as well use the component!
— Reply to this email directly, view it on GitHub https://github.com/the-collab-lab/tcl-67-smart-shopping-list/pull/120#discussion_r1552129544, or unsubscribe https://github.com/notifications/unsubscribe-auth/A2236M32CYNVFY7PVJWUMYTY3WEXBAVCNFSM6AAAAABFXP6FRCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSOBQGY4DONRRGY . You are receiving this because your review was requested.Message ID: <the-collab-lab/tcl-67-smart-shopping-list/pull/120/review/1980687616@ github.com>
Description
Sign in / Out buttons will now move to the footer for the mobile version of the application. Moves back into place when the window moves to desktop sizes. I decided not to try to move the welcome message as well, as it's part of another issue.
Related Issue
closes #116
Acceptance Criteria
Sign In/Out button is now properly within the footer of the page on mobile view.
Type of Changes
Enhancement.
Updates
Before
After
Testing Steps / QA Criteria
Resize your screen. Make sure the button moves to the footer.