implement typography

[aberger3647]

Description

Added fonts, weights, and sizes, and applied them to text accordingly. Some of the text came out too large when using the mockup, so I shrank them, and we can refine that further if we need to. When the font sizes grew, it affected the HTML/CSS, so changes were made there to return to the mockup design.

A few areas where this was not applied were in loading messages, "you don't have a list selected", and "no match for filter query". I will create another issue to address these.

Related Issue

92

Type of Changes

Enhancement

Updates

Before

After

Before

After

Before

After

Before

After

[github-actions[bot]]

Visit the preview URL for this PR (updated for commit a1b0206):

https://tcl-67-smart-shopping-list--pr96-feature-typography-athw8fu0.web.app

_{(expires Fri, 05 Apr 2024 21:57:50 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: 1dc6f6876568bd8a1c97781eec7984835c207f7c}

[aberger3647]

It does look strange! I didn’t bother with the button text since I knew we would work on that later. I meant to mention the welcome message. I think I just forgot to include it while doing the mockups. If we still want it we can think about where to put it/how to style it. I think it could be ok where it is, in the header. I can do a mock up of it?

On Fri, Mar 29, 2024 at 11:48 PM Jenny Takahara @.***> wrote:

@.**** approved this pull request.

Looks great Alex. The only text that looks kind of strange/small is the Welcome, Jenny Takahara and the buttons (other than sign out/sign in ones). I think in the mockups we aren't including the welcome message, so should we plan on removing that? And also I just assigned myself the issue for buttons, so I can tackle it in the next PR.

— Reply to this email directly, view it on GitHub https://github.com/the-collab-lab/tcl-67-smart-shopping-list/pull/96#pullrequestreview-1969803518, or unsubscribe https://github.com/notifications/unsubscribe-auth/A2236M4QP44MWQDUF6EGMRDY2Y73HAVCNFSM6AAAAABFO64DU6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSNRZHAYDGNJRHA . You are receiving this because you authored the thread.Message ID: <the-collab-lab/tcl-67-smart-shopping-list/pull/96/review/1969803518@ github.com>

[jtkabenni]

It does look strange! I didn’t bother with the button text since I knew we would work on that later. I meant to mention the welcome message. I think I just forgot to include it while doing the mockups. If we still want it we can think about where to put it/how to style it. I think it could be ok where it is, in the header. I can do a mock up of it? … On Fri, Mar 29, 2024 at 11:48 PM Jenny Takahara @.> wrote: @*.** approved this pull request. Looks great Alex. The only text that looks kind of strange/small is the Welcome, Jenny Takahara and the buttons (other than sign out/sign in ones). I think in the mockups we aren't including the welcome message, so should we plan on removing that? And also I just assigned myself the issue for buttons, so I can tackle it in the next PR. — Reply to this email directly, view it on GitHub <#96 (review)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/A2236M4QP44MWQDUF6EGMRDY2Y73HAVCNFSM6AAAAABFO64DU6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSNRZHAYDGNJRHA . You are receiving this because you authored the thread.Message ID: <the-collab-lab/tcl-67-smart-shopping-list/pull/96/review/1969803518@ github.com>

Hey Alex, yeah I think it could be a nice touch to keep it! @aberger3647