Closed stacy-tech closed 1 month ago
Visit the preview URL for this PR (updated for commit 09d7d42):
https://tcl-74-smart-shopping-list--pr24-sd-st-6-o6t0snvw.web.app
(expires Sat, 07 Sep 2024 15:09:30 GMT)
π₯ via Firebase Hosting GitHub Action π
Sign: 79d73546692f99aad8468c28e36db434e2c190ac
looks great! I would mention in the testing criteria that a list you share has to be one you created, but all seems to be working well!
We have updated the testing criteria. Thank you @NickRoccodev11
Tests worked for me! Well done! My only question pertains to shareList function. If it is an async function (firebase, line 140), would it make sense to add an await in ManageList? I'm wondering this myself. Great job!
Thank you for the feedback @dterceroparker ! We believe adding await in either Firebase.js file and ManageList.jsx would give the same result. So Stacy and I decided to keep the code as is.
Tests worked for me! Well done! My only question pertains to shareList function. If it is an async function (firebase, line 140), would it make sense to add an await in ManageList? I'm wondering this myself. Great job!
Thank you for the feedback @dterceroparker ! We believe adding await in either Firebase.js file and ManageList.jsx would give the same result. So Stacy and I decided to keep the code as is.
It may seem like the same result but it is slightly different! π
Description
Share List
button that can be activated using both themouse
and theenter
key.Related Issue
Acceptance Criteria
The ManageList view shows a form that allows the user to enter an email to invite an existing user to a list, in addition to the form that allows them to add items to that list.
Type of Changes
Enhancement
Updates
Before
After
Testing Steps / QA Criteria
Manage List
page.Share List
button or pressEnter
.