the-collab-lab / tcl-75-smart-shopping-list

2 stars 2 forks source link

Issue #7 | Filter shopping list to locate item in list #36

Closed dilekbaykara closed 2 months ago

dilekbaykara commented 2 months ago

Description

This PR allows users to search for items within their list, once the name of the item is typed into the input field, items within the list are then filtered to display items with the characters that were entered.

Related Issue

Acceptance Criteria

Type of Changes

enhancement

Updates

Before

Screenshot 2024-08-31 at 10 32 44 AM

After

Screenshot 2024-08-31 at 10 33 06 AM Screenshot 2024-08-31 at 10 33 16 AM

Testing Steps / QA Criteria

  1. Enter name of item in the input field
  2. Hit "X" button to clear filter function to return list to original state
  3. Test If unrelated item is entered, nothing will appear in list
github-actions[bot] commented 2 months ago

Visit the preview URL for this PR (updated for commit 716c9a3):

https://tcl-75-smart-shopping-list--pr36-wc-db-filter-shoppin-2m0fjs6p.web.app

(expires Sun, 08 Sep 2024 16:08:47 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 1f1fd53c369e1fa31e15c310aa075b4e8f4f8dde

ahsanatzapier commented 2 months ago

QA:

AC:

ahsanatzapier commented 2 months ago

Great work on this, team! I've left some suggestions in line with our commitment to clean up the code! I am deferring to @deeheber for the final approval since she's the weekly mentor!