Closed mike-marcacci closed 6 months ago
Note that complaints of "duplication" are primarily because tests and other high-duplication files were moved, causing them to be seen as "new code" by SonarCloud. We should ignore that gate for this PR.
Failed conditions
8.2% Duplication on New Code (required ≤ 3%)
These changes look good to me. It's strange that sonar is categorizing moved code as duplication.
Thanks @nickcarenza! Just to clarify Sonar's behavior: it already considers this code as duplicate in main
, but normally only reports on changes during PR scans, and because I moved them it considers them changed.
This has ended up becoming more substantial than originally intended. Several dependencies were abandoned or went completely different directions with major breaking changes.
This PR makes the following changes, many of them broken out into isolated commits when possible:
I explicitly avoided making substantial changes to the API or business logic – the purpose of this PR is strictly to bring this codebase up to date.