search

the-control-group / authx

An authentication & authorization platform for service-oriented architectures.
MIT License
47 stars 6 forks source link

Misc refinements from sonar #646

Closed mike-marcacci closed 6 months ago

mike-marcacci commented 6 months ago

This contains a number of fixes and refinements recommended by sonar. Some are meaningful, others less so.

Additional recommendations remain, but this covers all current recommendations labeled a "reliability" and many more.

sonarcloud[bot] commented 6 months ago

Quality Gate Failed Quality Gate failed

Failed conditions
17.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

mike-marcacci commented 6 months ago

I'm not loving sonar's "duplication" gates so much... they seem to encourage over-abstraction and discourage conformity. This codebase is overtly explicit, but this was an intentional choice.

Regardless, these additions aren't additions but rather blocks of existing code that was reformatted after applying recommended changes.