search

the-convocation / venat

open source ffxiv community discord bot that's incredibly easy to self-host
GNU Affero General Public License v3.0
16 stars 6 forks source link

feat(config): working config module + tests #70

Closed avafloww closed 2 years ago

avafloww commented 2 years ago

Describe your changes

yep. Also fixes migrations not being run, so you can turn DATABASE_SYNCHRONIZE=false again now when not doing any database work.

Issue ticket number and link

61

karashiiro commented 2 years ago

How do/Do we handle conflicting entity names across modules with this?

avafloww commented 2 years ago

How do/Do we handle conflicting entity names across modules with this?

As far as DB migrations go? We don't. I don't really know if there's a good answer to enforcing this, except maybe saying "please make your entity name like your module name, i.e. XivMarketSomething).

As far as config, it doesn't matter; config is stored per-module (keyed by the package name), subject type (global/guild/user), and subject (guild/user ID).

karashiiro commented 2 years ago

I don't really know if there's a good answer to enforcing this, except maybe saying "please make your entity name like your module name, i.e. XivMarketSomething).

Good enough for me, approving.