search

the-darkvoid / XPS9360-macOS

macOS Catalina on Dell XPS 9360
358 stars 86 forks source link

Clover vs OC Hotpatch Differences #152

Closed Nihhaar closed 4 years ago

Nihhaar commented 4 years ago

Why is there a difference between base64 encoding of _CRS in "change _CRS to XCRS in device TPD1 (TouchPad I2C)" patch of clover config.plist and oc config.plist? Thanks

FDNfQ1JTAA== -> 3_CRS (base64decode) X0NSUw== -> _CRS (base64decode)

Screenshot 2020-01-06 at 2 01 46 PM Screenshot 2020-01-06 at 2 03 52 PM
the-darkvoid commented 4 years ago

Clover uses a TgtBridge to limit the patch, while OpenCore uses only a table signature and skip value of 1. Because of this, the patch had to be adjusted.

Is there a problem with it?

Nihhaar commented 4 years ago

I understood that one (TgtBridge and table signature) but my question is why is the encoding of "_CRS" is different among the patches, X0NSUw== vs FDNfQ1JTAA==?

No problem but I'm just trying to understand the concept behind it.

the-darkvoid commented 4 years ago

As per your decoded content, the OC patch has an extra byte added to minimize the number of matches, because the area it searches through is larger due to missing TgtBridge functionality.

base64 encodes 6 bits per digit and we are displaying it here per 4 bits, which then changes the entire base64 string.

Nihhaar commented 4 years ago

That makes sense. Thank you. Will open this issue again if I have any doubt.