Using gameideventidx and playerid does not guarantee uniqueness across live play IDs. This is because sometimes the same player can be listed twice in the same event when the event type = PENALTY
For example:
Justin Williams Roughing against Tomas Tatar served by Justin Williams
Justin Williams is listed twice, each time with a different player_role: PENALTYON and SERVEDBY.
Therefore, we need to add player_role as part of the surrogate key for stg_nhl__live_plays
Changes
Details about what was changed
Other notes
Any other things that the reviewer should know about
Checks
[x] All models ran successfully
[x] Changes to models are reflected in the schema.yml
Pick one:
[x] No test failures OR
[ ] No new test failures, and there is a plan in place to address existing ones
Overview
Using
gameideventidxandplayeriddoes not guarantee uniqueness across live play IDs. This is because sometimes the same player can be listed twice in the same event when the event type =PENALTYFor example:
Justin Williams is listed twice, each time with a different
player_role: PENALTYON and SERVEDBY.Therefore, we need to add
player_roleas part of the surrogate key forstg_nhl__live_playsChanges
Other notes
Checks