Feature engineering: Corsi, Fenwick, & other shot features

[dmf95]

Overview

• Added Corsi, Fenwick, and other shot features to f_player_season.sql
• Resolves issue 48, & issue 50,

Changes

• Refactored all of the shot calculations such that we are able to attribute the shooter, and every other player that was on the ice as determined by the 2 arrays: home_skaters & away_skaters from f_plays
• Specifically, added the following new features:
  • shots_ff: Fenwick shots for while on the ice (goals, saved shots, missed shots)
  • shots_fa: Fenwick shots against while on the ice (goals, saved shots, missed shots)
  • shots_cf: Corsi shots for while on the ice (goals, saved shots, missed shots, blocked shots)
  • shots_ca: Corsi shots against while on the ice (goals, saved shots, missed shots, blocked shots)
  • shots_sf: Shots for while on the ice (goals, saved shots)
  • shots_sa: Shots against while on the ice (goals, saved shots)
  • shots_gf: Goals for while on the ice (goals)
  • shots_ga: Goals against while on the ice (goals)
  • shots_isog: Total individual shots on goal (goals, saved shots)
  • shots_iff: Total individual Fenwick shots for (goals, saved shots, missed shots)
  • shots_icf: Total individual Corsi shots for (goals, saved shots, missed shots, blocked shots)
  • shots_iblocked: Total individual shots that were blocked (blocked shots)
  • shots_imissed: Total individual shots that were missed (missed shots)
  • shots_isaved: Total individual shots that were saved (saved shots)
  • shots_iscored: Total individual shots that were goals (goals)
    • pcnt_ff: Fenwick for percentage (while on the ice) = Fenwick shots for / (Fenwick shots for + Fenwick shots against)
    • pcnt_cf: Corsi for percentage (while on the ice) = Corsi shots for / (Corsi shots for + Corsi shots against)
    • pcnt_sf: Shots for percentage (while on the ice) = Shots for / (Shots for + Shots against)
    • pcnt_gf: Goals for percentage (while on the ice) = Goals for / (Goals for + Goals against)
• Changed all of the pcnt_ features from decimal to percent (%) by multiplying them all by 100

  Other notes

• You are awesome.

Checks

• [ ] All models ran successfully
• [ ] Changes to models are reflected in the schema.yml Pick one:
• [ ] No test failures OR
• [ ] No new test failures, and there is a plan in place to address existing ones

[nkumar97]

let's get that money!