the-data-base / nhl-data

Repo for version control the dbt transformations on nhl-breakouts data
5 stars 0 forks source link

Feature engineering shot rebounds #66

Closed dmf95 closed 2 years ago

dmf95 commented 2 years ago

Overview

Changes

  1. stg_nhl__live_plays
    • added last_shot cte: each row in this dataset was a shot taken by the shooter/goalscorer within regulation/OT... added lag features denoted by the prefix last_shot_ with the intention of using them to create shot-features later on, including rebound classification
    • refactored code for readability
    • updated the dependent yml file
  2. f_plays
    • added last_shot_ features, in addition to creating last_shots_seconds & last_shot_rebound_ind
    • updated the dependent yml file
  3. f_player_season
    • addedlast_shot_rebound_ind an summarized it to created 4 new rebound features: shots_rebound_all, shots_rebound_saved, shots_rebound_goal, pcnt_shooting_rebound
    • updated the dependent yml file

      Other notes

    • Nah.

      Checks

    • [ ] All models ran successfully
    • [ ] Changes to models are reflected in the schema.yml Pick one:
    • [ ] No test failures OR
    • [ ] No new test failures, and there is a plan in place to address existing ones