the-database / VideoJaNai

GUI for upscaling ONNX models with NVIDIA TensorRT and Vapoursynth
GNU General Public License v3.0
112 stars 5 forks source link

Value in wrong format is written to config on Windows with Russian localization #12

Closed Gebcy closed 3 months ago

Gebcy commented 7 months ago

error.log (Version 0.0.9)

Config with incorrect values on Russian localization: chain_1_rife_factor_numerator=5,0 chain_1_rife_factor_denominator=1,0 chain_1_rife_scene_detect_threshold=0,100

Config with correct values on English localization: chain_1_rife_factor_numerator=5.0 chain_1_rife_factor_denominator=1 chain_1_rife_scene_detect_threshold=0.10

I think this is due to regional differences in number formats. And this may happen not only with Russian localization, but also with all localizations that use a comma instead of a dot as a decimal separator.

the-database commented 3 months ago

Fixed in v1.0.0