Application Detail: Quick Overview

JigSays commented 4 years ago

As an admin, I want to be able to open an application and quickly be provided useful information.

Only implement the top portion

Acceptance Criteria:

[x] Appears at the top of the application detail page
[x] Has the application name displayed
[x] Has the Healthcare Provider name displayed
[x] Has the Family Member representative name displayed
[x] Has the application Created date displayed
[x] Has the Grant Amount Requested displayed
[x] Has an "edit" button to allow changes to be made

UPDATES 02/18/2021

[x] Ability to redirect back to the home page when KSF logo is clicked
[x] Ability to see the Search bar at the top of the page as well as on the Applicant Detail page

sierrastephens commented 3 years ago

@lsysophia can we update the display of the money amount to have cents & comma formatting? (i.e. $200,000.00)

sierrastephens commented 3 years ago

@lsysophia also, it does not look like the "Edit" button is functional at the moment - which relates to the last AC " Has an "edit" button to allow changes to be made" . let me know if you have a moment to chat we can run through questions/concerns.

nancyhlin commented 3 years ago

@lsysophia Couple of things that are missing from this ticket --

Can you please add a redirect to back to the home page when the user clicks on the KSF logo?
Can you add the search bar to the top of the page? The search bar should be visible on the home page as well as the Application Page.

H12 commented 3 years ago

@nancyhlin Were the redirect and search bar part of this ticket? From the initial description it looks like we were only supposed to implement the portion of the paged marked with the "1".

JigSays commented 3 years ago

@H12 This ticket was exclusive to the application details and thus ignored the master search bar above it. I believe that search bar to be apart of the "home screen" and just stays "present"...as you should not need to search within the application detail.

H12 commented 3 years ago

@JigSays Okay, so if I'm understanding correctly @lsysophia does not need to implement home screen redirect and search bar functionality as part of this ticket?

And if I am understanding correctly, is there another ticket to address that functionality?

JigSays commented 3 years ago

Yes, search does not need to be implemented in this ticket. As we wouldn't need search within the application detail section.

The search bar here would only be used to search for another application and pull the user back to the homepage | search results.

lsysophia commented 3 years ago

Wait, I'm confused now. The search bar within this component does not search within the application details, it searches for additional applications. Was that all unnecessary then..?

JigSays commented 3 years ago

@lsysophia sorry for any confusion...the search bar is working great. I was just saying we didn't need to implement it to go thru the particular applicant detail and perform a search. The search bar above it should still do a database search and return relevant applications to the search results display screen.

For example: if an application references healthcare provider Emily Page, and you use the search bar above to search "Emily" it should return all applications containing "Emily" not highlight where in this particular application "Emily" was mentioned.

lsysophia commented 3 years ago

ok understood, thank you @JigSays ! The search bar component is working the way you described. I think maybe @H12 was asking if this search component is in addition to the original ticket and if this should have been implemented as a separate ticket. I had the same question too originally, but I thought the changes were needed for demo, so I implemented them. Anyways, I'll leave it to you guys to decide how to move forward then! :)

H12 commented 3 years ago

Yeah I was just confused why the original description of this ticket didn't match the functionality you implemented in your PR, @lsysophia.

Since you already implemented Search and Redirect, there's absolutely no need to remove it! I just wanted to get a more detailed description of what our use-cases were for search & redirect so I could ensure the code in your PR did what we wanted.

Hopefully I didn't cause any confusion!

In the future, since this functionality wasn't part of the original ticket's description, I think it would make more sense to address it in a new ticket rather than tacking it onto an existing one as part of UAT review. At the very least it'd make it much easier for me to tie code-changes to design use-cases during the PR review process.

No reason to do that retroactively here, just something to keep in mind going forward.

hmichele commented 3 years ago

@lsysophia Please increase the text size for the application name and data in the overview section to match the screenshot.

the-difference-engine / ksf

Application Detail: Quick Overview #117