the-difference-engine / ksf

7 stars 1 forks source link

Display Application After a Search Result is Displayed #137

Closed JigSays closed 3 years ago

JigSays commented 3 years ago

As an admin, when I use the search bar and a result is returned I would like to be able to click on the resulting applications and open them in the Application Detail format (page).

From Here: Screenshot 2020-11-18 20.16.13.png

To here: Screenshot 2020-11-18 20.16.27.png

Acceptance Criteria:

nancyhlin commented 3 years ago

Added styling acceptance criteria

hmichele commented 3 years ago

@lsysophia Per our conversation, please include a message that indicates there are no nominations if none are found, a way to exit the search results screen back to the previous page and modify the search results table to the same styling as what's on the dashboard.

lsysophia commented 3 years ago

The current solution to redirecting from the search result card back to the previous page is utilizing the useHistory hook provided by 'react-router-dom'. (references: 1;2) Not sure if this is the correct way to approach the problem. It's working but not perfectly yet. At this point, you'll have to click on the 'X' exit button on the search result card twice in order to trigger a re-render to the previous page..

The message that indicates no nominations if none are found and the search result table styling have not started yet.

hmichele commented 3 years ago

@Lcole490 @hedrarowan

Please make the following changes:

image.png

Please make sure the search is only bringing back applications that contain what is typed in the search bar from Application Name, Provider's Name or Patient Name. I'm seeing applications that don't contain that text.

hmichele commented 3 years ago

@Lcole490 @hedrarowan Please change the "Provider's Name" header to "HP Name".