Verification Link Within Healthcare Provider Email

sierrastephens commented 3 years ago

As a user, I want to verify the Healthcare provider's email address via a verification link within the Healthcare provider email. Please note: this ticket is apart of #23, which covers the Healthcare Provider Email. This ticket will only cover the detail of the verification link needed to confirm ownership within the email.

Acceptance Criteria

[x] Send a verification link within the Healthcare Provider Email leveraging a unique identifier/code.
[x] Verification link within the Healthcare Provider Email is clickable
[x] Verification link redirects to blank page that says: "Thank you for verifying your email! " to confirm ownership
[x] Update nomination model: Email Validate parameter to True
[x] The generated one time verification link will only be valid for 7 days
[x] Ability to flag "public domain" email in the nomination model

sierrastephens commented 3 years ago

Cannot test this ticket until ticket #23 passes. moved ticket #23 back into "In Progress," since the emails are not sending. CC: @JigSays @nancyhlin @hmichele @sowmya20189

nancyhlin commented 3 years ago

Updated Acceptance Criterias and moved back to In Progress:

[ ] Send a verification link within the Healthcare Provider Email leveraging a unique identifier/code.
[ ] Verification link within the Healthcare Provider Email is clickable
[ ] Verification link redirects to blank page that says: "Thank you for verifying your email! " to confirm ownership
[ ] Update nomination model: Email Validate parameter to True
[ ] The generated one time verification link will only be valid for 24 hours

nancyhlin commented 3 years ago

@bwalborn I added the last acceptance criteria: The ability to flag the email as a 'public domain' email. If the email is from a public domain, it will not move forward in the application process. The system will only process private emails that are whitelisted.

floresjmjr commented 3 years ago

So currently the verification link uses the local domain (localhost:3000) and not the heroku app domain. Making that switch now.

sierrastephens commented 3 years ago

Anna & Jorge to meet 9/20, or by 9/23 at the latest for testing approach on triggering email.
Fix for verification link PR planned by 9/20 or 9/23 at the latest.

floresjmjr commented 3 years ago

just an fyi, At the moment when a new nomination is created the application sends a verification email automatically. It does not first check to see if the provider email address has already been validated in a previous nomination. This is with respect to when a nomination is created in googlesheets (by inserting a row), not with an api call (post request with nomination data).

annamot9 commented 3 years ago

@floresjmjr @johnLeavell as the health care provider, when I click the link it takes me erroneous page.

annamot9 commented 3 years ago

@johnLeavell I have tested the link from an verification email I received on Monday and it still brought me to the relevant page.

sowmya20189 commented 3 years ago

Updated the AC - The email verification link will be valid / active for 7 days instead of 24hours. Please make the changes accordingly. @johnLeavell @chavalk

johnLeavell commented 3 years ago

Updated verification link expiration. Awaiting approval

the-difference-engine / ksf

Verification Link Within Healthcare Provider Email #173