search

the-difference-engine / ksf

7 stars 1 forks source link

Node version check #265

Closed somersbmatthews closed 3 years ago

somersbmatthews commented 3 years ago

Zenhub Link:

Describe the problem being solved:

Prevents sequelize varchar error with node >= 15 Added .nvmrc with node version check code to root directory but it sure as shootin' won't work like if copied into in /packages/api with similarly modified package.json with added "engines" object (unsure why)

Impacted areas in the application:

node

Describe the steps you took to test your changes:

ran npm run dev in /packages/api after nvm use 14 and nvm use 15, code works and triggers error in any node > 14.17.0 List general components of the application that this PR will affect: none PR checklist

somersbmatthews commented 3 years ago

@aschey changed code in two places (root directory package.json and /packages/api/package.json) to include range of node versions from 14 to 14.17.0