search

the-difference-engine / ksf

7 stars 1 forks source link

Ticket 301 #308

Closed claudiahalip closed 3 years ago

claudiahalip commented 3 years ago

Zenhub Link:

https://app.zenhub.com/workspaces/ksf-5f23520d91f7ee00134cbaf6/issues/the-difference-engine/ksf/301 Screen Shot 2021-07-29 at 8 27 34 AM

Describe the problem being solved:

  1. Grey out the buttons (Decline application and Mark stage as complete)
  2. Button functionality shouldn't work (It shouldn't be clickable)

Impacted areas in the application:

components/applicationStages components/nominationBanner

Describe the steps you took to test your changes:

checked with product for the styling, clicked the buttons to change the status and checked if the buttons are disabled and gery.

List general components of the application that this PR will affect: components/applicationStages : /app/src/components/applicationStages/modals/MarkStageAsCompleteModal.js app/src/components/applicationStages/ApplicationStages.js app/src/components/applicationStages/style.css components/nominationBanner: app/src/components/nominationBanner/nominationBanner.js app/src/components/nominationBanner/style.css

PR checklist

claudiahalip commented 3 years ago

Looks good. One thing I noticed (which is probably from the previous PR) is that the red status bar ends in a point, whereas the others (I think?) have a rounded edge on both ends. Do we want that right end to be rounded, as well?

Yes, I think should be rounded. I will take a look right now and try to fix it.