search

the-difference-engine / ksf

7 stars 1 forks source link

modal styling changed #317

Closed claudiahalip closed 3 years ago

claudiahalip commented 3 years ago

Zenhub Link:

Describe the problem being solved: the modal styling and text changed

Impacted areas in the application:

app/src/components/nominationBanner/nominationBanner.js app/src/components/nominationBanner/style.css

Describe the steps you took to test your changes:

If this ticket involves any UI or email changes, please provide a screenshot that shows the updated UI

Screen Shot 2021-08-02 at 8 43 54 PM

List general components of the application that this PR will affect: app/src/components/nominationBanner/nominationBanner.js app/src/components/nominationBanner/style.css

PR checklist

claudiahalip commented 3 years ago

Let's try to reuse the modal CSS between this and this PR #322 so the modal styling stays consistent.

Can I wait until PR#322 is merged and than reuse its CSS for this modal?

vhoof commented 3 years ago

Per discussion in Slack, Claudia's going to work on consolidating these and will likely close one of the PRs.

aschey commented 3 years ago

Thanks @claudiahalip can you provide screenshots of both the decline modal and the mark stage as complete modal with the updated CSS?

claudiahalip commented 3 years ago

Thanks @claudiahalip can you provide screenshots of both the decline modal and the mark stage as complete modal with the updated CSS?

Screen Shot 2021-08-12 at 7 36 27 PM Screen Shot 2021-08-12 at 7 36 05 PM