the-difference-engine / ksf

7 stars 1 forks source link

removed hover for buttons #322

Closed johnLeavell closed 3 years ago

johnLeavell commented 3 years ago

Zenhub Link: https://github.com/the-difference-engine/ksf/issues/307

Describe the problem being solved: Changed styling of the modal

Impacted areas in the application: Application stages style.css

Describe the steps you took to test your changes:

If this ticket involves any UI or email changes, please provide a screenshot that shows the updated UI

Screen Shot 2021-08-05 at 8 20 40 PM

List general components of the application that this PR will affect: ksf/packages/app/src/components/applicationStages/style.css

PR checklist

claudiahalip commented 3 years ago

It looks like this modal should look the same as the one in this PR #317 maybe we can try to reuse the CSS between these two modals so they look consistent. That one has two grey horizontal lines that I think this one needs as well.

Michele asked me to remove the horizontal grey lines when I worked on the other modal(decline application button- ticket233) Screen Shot 2021-08-09 at 7 10 08 PM

aschey commented 3 years ago

It looks like this modal should look the same as the one in this PR #317 maybe we can try to reuse the CSS between these two modals so they look consistent. That one has two grey horizontal lines that I think this one needs as well.

Michele asked me to remove the horizontal grey lines when I worked on the other modal(decline application button- ticket233) Screen Shot 2021-08-09 at 7 10 08 PM

Okay, thanks for clarifying. I think we should still try to combine the CSS between the two unless they need to look different for some reason.

claudiahalip commented 3 years ago

It looks like this modal should look the same as the one in this PR #317 maybe we can try to reuse the CSS between these two modals so they look consistent. That one has two grey horizontal lines that I think this one needs as well.

Michele asked me to remove the horizontal grey lines when I worked on the other modal(decline application button- ticket233) Screen Shot 2021-08-09 at 7 10 08 PM

Okay, thanks for clarifying. I think we should still try to combine the CSS between the two unless they need to look different for some reason.

ok, we will do that tonight

claudiahalip commented 3 years ago

centralizing the CSS for bot model on PR317