the-difference-engine / ksf

7 stars 1 forks source link

Ticket173 #333

Closed johnLeavell closed 3 years ago

johnLeavell commented 3 years ago

Zenhub Link: https://github.com/the-difference-engine/ksf/issues/173

Describe the problem being solved:

Send a verification link within the Healthcare Provider Email leveraging a unique identifier/code. Verification link within the Healthcare Provider Email is clickable Verification link redirects to blank page that says: "Thank you for verifying your email! " to confirm ownership Update nomination model: Email Validate parameter to True The generated one time verification link will only be valid for 24 hours Ability to flag "public domain" email in the nomination model

Impacted areas in the application:

detail of the verification link needed to confirm ownership within the email

Describe the steps you took to test your changes:

created a script to send email to confirm verification of email address.

If this ticket involves any UI or email changes, please provide a screenshot that shows the updated UI

Screen Shot 2021-08-19 at 6 51 54 PM

Screen Shot 2021-08-19 at 6 53 05 PM

List general components of the application that this PR will affect:

PR checklist

floresjmjr commented 3 years ago

What to do about package-lock.json changes? I noticed those but don't understand why they were added.

aschey commented 3 years ago

What to do about package-lock.json changes? I noticed those but don't understand why they were added.

Looks like that got added in the first commit. Not sure how exactly but it should be safe to just remove those few lines that got added.

vhoof commented 3 years ago

You should be able to git checkout develop -- package-lock.json packages/app/package-lock.json packages/api/package-lock.json, which will pull the versions from the develop branch. You may want to git checkout develop && git pull and switch back to your branch to make sure you have the latest, first.

Otherwise, just deleting the changes manually should work, like Austin mentioned.