the-difference-engine / ksf

7 stars 1 forks source link

197 reminder email notifications #349

Closed floresjmjr closed 2 years ago

floresjmjr commented 2 years ago

Zenhub Link:

https://app.zenhub.com/workspaces/ksf-5f23520d91f7ee00134cbaf6/issues/the-difference-engine/ksf/197

Describe the problem being solved:

The HIPAA reminder email and the Survey reminder email weren't being sent. It appears that when the script 'reminder-emails' is executed, the emails aren't sent because the environmental variables used are 'undefined' due to the 'dotenv' configuration. The email templates also needed to be updated based on the links provided.

Impacted areas in the application:

It impacts the notifications that are sent when the application is in the "AwaitingHIPAA" or "HIPAA Verified" stage. It also impacts the content of the emails (survey reminder and hipaa reminder) that are sent.

Describe the steps you took to test your changes:

I ran the script, 'npm run reminder-emails' while making sure there was an application in that status and reducing the time to a few minutes old instead of 7 days old. (switched it back to 7 days afterwards) Viewed the emails I received to make sure the content matched the template and header was being displayed.

If this ticket involves any UI or email changes, please provide a screenshot that shows the updated UI

Only included the family representative emails, even though the reminders are sent to both the family and health provider emails.

Screen Shot 2021-09-22 at 8 51 30 PM

Screen Shot 2021-09-22 at 8 52 05 PM

Screen Shot 2021-09-22 at 8 52 34 PM

Screen Shot 2021-09-22 at 8 52 53 PM

Screen Shot 2021-09-22 at 8 54 11 PM

Screen Shot 2021-09-22 at 8 54 40 PM

List general components of the application that this PR will affect: api/emails/surveyReminder/html.pug api/emails/hipaaReminder/html.pug api/controllers/nominations.js api/helper/reminderEmails.js api/models/nomination.js api/helper/mailer.js

PR checklist