search

the-difference-engine / ksf

7 stars 1 forks source link

changed the domain for the link being sent via email to allow for tes… #350

Closed floresjmjr closed 2 years ago

floresjmjr commented 2 years ago

…ting using the heroku app instead of the local app

Zenhub Link:

https://app.zenhub.com/workspaces/ksf-5f23520d91f7ee00134cbaf6/issues/the-difference-engine/ksf/173

Describe the problem being solved:

The verification link only works if the local app is running as the link uses the local domain (localhost:3000) instead of the heroku app domain. Made the change using an existing env variable.

Impacted areas in the application:

It impacts the verification email that is clicked on by the Health provider.

Describe the steps you took to test your changes:

Created the nomination using the local api test file. After receiving the email, I clicked on the link and made sure it was using the right domain.

If this ticket involves any UI or email changes, please provide a screenshot that shows the updated UI

N/A List general components of the application that this PR will affect: api/helper/mailer.js

PR checklist

floresjmjr commented 2 years ago

After speaking with Austin, I realized that the env variable I used (APP_URL) that has a value of 'localhost:3000' in the dev stage actually a different value in production (it has the heroku domain). That means no code changes need to be made. However when testing the issue, which at the moment can only be done within the dev stage, the env variable needs to be change to the heroku domain.