search

the-difference-engine / ksf

7 stars 1 forks source link

Bug: Typo in the Request for HIPPA email #357

Closed annamot9 closed 2 years ago

annamot9 commented 2 years ago

In the email sent to the family representative, there is a typo in the word Acquire. image.png

somersbmatthews commented 2 years ago

https://github.com/the-difference-engine/ksf/blob/6eda70c01da96fec7abe8ab8897807dd922df478/packages/api/emails/hipaa/html.pug#L42

annamot9 commented 2 years ago

Somers opening a PR.

annamot9 commented 2 years ago

@somersbmatthews The error is not fixed. image.png

somersbmatthews commented 2 years ago

https://github.com/the-difference-engine/ksf/blob/da20d8c5194b58ab16bee8f222ffe14aeedbc572/packages/api/emails/hipaaReminder/html.pug#L58

it's fixed here, the app on someones computer that sends these emails has to pull from develop branch and merge with their local branch, then their local branch will send the correct email.

somersbmatthews commented 2 years ago

if you can send an email from a staging app, like the one on heroku, that should have the most recent develop branch (but not really sure how the staging app works), so the email will have the correct spelling of "acquire".

annamot9 commented 2 years ago

The typo has been successfully fixed.