the-difference-engine / ksf

7 stars 1 forks source link

completed second criteria #362

Closed johnLeavell closed 2 years ago

johnLeavell commented 2 years ago

Zenhub Link:https://github.com/the-difference-engine/ksf/issues/251

Describe the problem being solved:

The Survey email to the health care provider will be sent when the application has been moved forward from "Awaiting HIPPA" to "HIPPA Verified" status

Impacted areas in the application:

nomination controller (nomination.js)

Describe the steps you took to test your changes

moved application to hipaa verified stage and made sure that the health provider received the survey email.

If this ticket involves any UI or email changes, please provide a screenshot that shows the updated UI

List general components of the application that this PR will affect: nomination controller (nomination.js) PR checklist

floresjmjr commented 2 years ago

while working in this ticket I noticed the usage of the 'reminderSent' property which we currently dont use in the application so I removed it in a commit. Also Sommers pointed out an issue with the migration file "remove_reminder" and it seems PR Ticket 277 has fixed this so I removed my commit fix.