somersbmatthews
commented
2 years ago Is there a reason to search by all three columns? "by patient last name, and hospital city and state."
Here is a spreadsheet of what the nominations table looks like in the database, for reference: nomination table in database
Some rows might have duplicated values for these three columns and you might not get the correct google folder id for the nomination to which this email refers.
Perhaps we can use the unique identifier in the first column in the database?
I'm sorry, I don't know how the exactly how emails work from a product perspective in this project (like when and from where this email is received by ksf). I suspect this email is sent when the "mark stage as complete" button is pressed the first time (but really not sure). I have experience in using unique identifiers in emails from users in production to read from and update specific rows in a database. If we can schedule a talk about this in the future, I think we can formulate a for sure way to guarantee getting the correct google drive folder id from the db in order to update the google drive folder that belongs to the exact nomination to which this email would specifically refer.
It would be one less step for things to go wrong, and would guarantee that the documents get to where they need to go in google drive.
There was probably a talk among ksf product and perhaps tech leads that I was not involved in about this ticket. I am proposing that a plan to use the unique identifier instead of the three columns mentioned would be a better way to go about this ticket.
sowmya20189
In order to better find the right application folder to add the attachments that are being received, since the folder ID is kept in the DB, the search should use that to find the right folder. The search for the folder ID should be by patient last name, and hospital city and state.
Acceptance Criteria: [ ] When the email received to the nomination@keepswimmingfoundation.org with attachments is being processed, since the patient last name, hospital city and hospital state appear in the subject of the email, the search should find the application in the DB and retrieve the folder ID. [ ] Once the folder ID is identified, the attachment from the email should be added to the folder.