search

the-difference-engine / ksf

7 stars 1 forks source link

326 declined applications date refactor #374

Closed t-keazirian closed 2 years ago

t-keazirian commented 2 years ago

Zenhub Link:

https://app.zenhub.com/workspaces/ksf-5f23520d91f7ee00134cbaf6/issues/the-difference-engine/ksf/326

Describe the problem being solved:

The grant cycle section will show both Ready for Board Review and Declined applications - it will place them in the grant cycle that aligns with the date that they were either Declined or Ready for Board Review. If they are declined, the nomination name will appear in red.

Impacted areas in the application:

Settings modal

Describe the steps you took to test your changes:

tested locally

If this ticket involves any UI or email changes, please provide a screenshot that shows the updated UI

Screen Shot 2021-10-20 at 7 02 04 PM

Screen Shot 2021-10-20 at 7 01 55 PM

List general components of the application that this PR will affect: Settings Modal, Toggle Active Grant Cycle, Table Row

PR checklist

somersbmatthews commented 2 years ago

@aschey ready to be reviewed, application form reversed offset date fixed removed.