the-difference-engine / ksf

7 stars 1 forks source link

#245 Adding validation and function to override emails #383

Closed KeenanJones1 closed 2 years ago

KeenanJones1 commented 2 years ago

Zenhub Link: https://app.zenhub.com/workspaces/ksf-5f23520d91f7ee00134cbaf6/issues/the-difference-engine/ksf/245

Describe the problem being solved: Enable email recipients to be globally overridable

Impacted areas in the application: The Mailer directory in Backend

Describe the steps you took to test your changes: Created a function to check if a RECIPIENT_EMAIL has a valid email and the SEND_TO_TEST variable equals true in the api .env file.

If this ticket involves any UI or email changes, please provide a screenshot that shows the updated UI

No changes to the UI but to test this ticket two variables must be added to the api .env file: RECIPIENT_EMAIL must be a valid and targeted email address to test and SEND_TO_TEST must be a boolean.

List general components of the application that this PR will affect: Emails and mailers in the api PR checklist

aschey commented 2 years ago

Looks like tests are failing too, probably want to take a look at that