search

the-difference-engine / ksf

7 stars 1 forks source link

326 decline nomination fail #388

Closed Geoff7709 closed 2 years ago

Geoff7709 commented 2 years ago

Zenhub Link:

https://app.zenhub.com/workspaces/ksf-5f23520d91f7ee00134cbaf6/issues/the-difference-engine/ksf/326

Describe the problem being solved:

Applications appearing in red in grant cycle after they have been declined from the Settings modal.

Impacted areas in the application:

Settings Modal

Describe the steps you took to test your changes:

Cannot be tested with the data we currently have - it needs to be merged with develop to be tested in the staging app

If this ticket involves any UI or email changes, please provide a screenshot that shows the updated UI

No List general components of the application that this PR will affect: Settings.js PR checklist

Geoff7709 commented 2 years ago

From what I can tell, this change 

if (nomination.dataValues.readyForBoardReviewTimestamp == null) {
            nomination.update({
              readyForBoardReviewTimestamp: Date(), 
              declinedTimestamp: Date(),
              grantCycleId: grant.id,
            })
          } else {
            nomination.update({
              declinedTimestamp: Date(),
              grantCycleId: grant.id,
            })
          };

to the contollers/nomination.js file fixes the disappearing nominations bug in the Edit modal. It just makes it so that if there is already a readyForBoardReviewTimeStamp value, then it is not updated. The nomination is not kicked out of the grant cycle if you're declining it outside of the grant cycle itself.