the-difference-engine / ksf

7 stars 1 forks source link

removed extra button and replaced with appropriately styled button #394

Closed Geoff7709 closed 2 years ago

Geoff7709 commented 2 years ago

Zenhub Link:

https://app.zenhub.com/workspaces/ksf-5f23520d91f7ee00134cbaf6/issues/the-difference-engine/ksf/391

Describe the problem being solved:

Two "Decline Nomination" buttons on the Nomination Banner

Impacted areas in the application:

Nomination Banner

Describe the steps you took to test your changes:

There were two buttons in JSX for the component, one of which was the sub-component for the decline button. The other was a generic button that accessed the same routes. I removed the generic button, replaced it with the appropriately styled sub-component for the Decline Button. This automatically spaced the "Resend Email" evenly between the Decline and Edit buttons. Clicking the remaining Decline button retains the same functionality.

If this ticket involves any UI or email changes, please provide a screenshot that shows the updated UI

Capture List general components of the application that this PR will affect: nominationBanner.js PR checklist

Geoff7709 commented 2 years ago

As requested did run of tests on the branch, and the Decline button is working as it should. If the positioning is good, it should be ready to merge.